[Bug 756435] Review Request: pytorctl - Python bindings for controlling the Tor router

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=756435

--- Comment #3 from Juan Orti Alcaine <j.orti.alcaine@xxxxxxxxx> 2011-12-21 08:34:50 EST ---
(In reply to comment #2)

Thank you for your suggestions, I have updated the files:

Spec URL:
https://raw.github.com/jorti/pytorctl-fedora-package/v0-0.8.20111213git/SPECS/pytorctl.spec
SRPM URL:
https://github.com/jorti/pytorctl-fedora-package/raw/v0-0.8.20111213git/SRPMS/pytorctl-0-0.8.20111213git.fc16.src.rpm

> Why do you prevent RHEL5 from building this as noarch?  RHEL 5 handles noarch
> packages just fine.  (It's noarch *subpackages* of arch-dependent packages that
> are an issue.)

Ok, I got it wrong, now it's fixed.

> Please use "cp -p" to retain timestamp information from upstream.  
> 
> Also, consider doing something like "install -pm0755" to avoid having to chmod
> everything post-copy.  (It's not necessary, but simpler.)

I applied those permissions because rpmlint was giving errors. I have fixed
this by installing the files without execution and removing the python shebang
from the files as seen here:
http://fedoraproject.org/wiki/Packaging_tricks#Remove_shebang_from_Python_libraries

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]