Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719854 --- Comment #39 from Vít Ondruch <vondruch@xxxxxxxxxx> 2011-12-21 04:51:56 EST --- (In reply to comment #38) > Vít, > > I'd like to sponsor Ulrich as I know he knows what he is doing but while my > packaging is generally good my ruby is less so. > > This package looks almost good to me but if you have further comment I would be > grateful, this turns out to be a non-trivial ruby package. > > The alternative is I release this as being assigned to me. > > Steve. > > Problems I still see however: > > (1) > Requires: ruby-libs > > is almost certainly not needed and is you get anyway from both > libruby.so.1.8()(64bit) > ruby(abi) = 1.8 > > the first one of which in particular is autogenerate, basically you should > not added which is determined automatically anyway. Actaully the 'ruby-libs' should be replaced with 'ruby', as is stated in Ruby packaging guidelines. > (2) > The fact the package contains the origional gem seems bad. > > /usr/lib/ruby/gems/1.8/cache/xmlparser-0.6.81.gem > > it should not. Although there is a lot of gems which keeps the original gem in the RPM and it is not against packaging guidelines, I also recommend to use %exclude for the cached gem. Otherwise I am fine with the package. Feel free to approve it and sponsor Ulrich any time. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review