Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769096 --- Comment #3 from Willington Vega <wvega@xxxxxxxxx> 2011-12-21 00:27:55 EST --- Yader, Thank you for the quick reply. First I want to be clear about the kind of review I'm doing. I'm still learning the packaging guidelines and I do informal reviews as a way to gain a better understanding of how properly create packages for Fedora. I'm not allowed to approve or reject this package. At some point someone will do an official review and decide whether the package is ready to be included or not. All we are doing right is trying to improve the package to save some time to the official reviewer. When you update your spec is expected that you provide the URL for the updated SPEC and SRPM. There should be a different URL for each update and you should increase the release number in the SPEC file and add the corresponding entry to the changelog section. For the Source0, I didn't consider using spectool. It works. I think the official reviewer should decide which one is the best practice in this case. If you provide the updated SPEC I will continue with the informal review. Have you introduced yourself to fedora-devel-list[1][2]? 1. http://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Introduce_yourself 2. http://www.redhat.com/mailman/listinfo/fedora-devel-list -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review