Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=760033 --- Comment #6 from Kevin Kofler <kevin@xxxxxxxxxxxxxxxx> 2011-12-20 19:15:43 EST --- IMHO, the subpackages are fine as is, the openSUSE version is excessively split. Some comments (not a complete review yet): > Release: %{snapshot}%{?dist}.1 should be: Release: 0.1.%{snapshot}%{?dist} The next builds should then be 0.2.%{snapshot}%{?dist}, 0.3.%{snapshot}%{?dist} etc. BuildRequires are global, so I'd list them all together at the beginning (but putting them where you put them works, too). > #remove executable bit > chmod 644 %{buildroot}/%{_kde4_datadir}/applications/kde4/timetablemate.desktop Not sure about that one… We don't normally do this, i.e. we keep the +x bit upstream sets, but some non-KDE folks want us to do what you did everywhere. In practice, it will work either way because KDE Plasma does not require the +x bit in the standard prefix. You put the icon scriptlets into the main package and the actual icons into -libs. They should be in the same package. (IMHO in the main package. Those icons shouldn't be multilibbed.) That's all I can spot at first glance, I haven't done a complete systematic review yet though. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review