[Bug 759760] Review Request: perl-Encode-JIS2K - JIS X 0212 (aka JIS 2000) Encodings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=759760

Ville Skyttä <ville.skytta@xxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody@xxxxxxxxxxxxxxxxx    |ville.skytta@xxxxxx
               Flag|                            |fedora-review?

--- Comment #1 from Ville Skyttä <ville.skytta@xxxxxx> 2011-12-20 16:15:37 EST ---
* Why include the ucm dir in docs?  I think it's essentially 1.2M of source
code that's not useful when installed.

* Package is uninstallable after being built in Rawhide, it requires
perl(Encode::JIS2K::2022JP3) which isn't provided by the package itself nor
anything else in Fedora.  Just a hunch, maybe the package declaration at top of
lib/Encode/JIS2K/2022JP3.pm should be Encode::JIS2K::2022JP3 instead of
Encode::JIS7::2022JP3.

See the rpmdevtools perl spec template, following it would have prevented these
issues:

* perl-Encode-JIS2K.x86_64: E: zero-length
/usr/lib64/perl5/vendor_perl/auto/Encode/JIS2K/JIS2K.bs

* OPTIMIZE="$RPM_OPT_FLAGS" missing from Makefile.PL line.

* Unnecessary ownership of /usr/lib64/perl5/vendor_perl/auto dir, already owned
by perl-libs.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]