Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-pear-PHP_CodeSniffer - PHP coding standards enforcement tool Alias: pear-CodeSniffer https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225341 ------- Additional Comments From chris.stone@xxxxxxxxx 2007-01-29 19:56 EST ------- ==== REVIEW CHECKLIST ==== - rpmlint output clean X package is not named according to package naming guidelines - spec file name matches %{name} - package meets packaging guideliens - licensed with open source compatible license - license in spec matches actual license - license file included in %doc - spec written in American english - spec file legible - sources match upstream 9b13c0cad263a1e7044b8135b37a1c93 PHP_CodeSniffer-0.3.0.tgz - successfully compiles and builds on FC-6 x86_64 - all build dependencies listed in BR - no locales - no shared libraries - not relocatable X package does not own all directories it creates - no duplicates in %files - file permissions set properly - contains proper %clean - macro usage is consistent - contains code - no large documentation - %doc does not affect runtime - no header files or static libraries - no pkgconfig files - no library files with suffix - no need for devel subpackage - no libtool archives - not a GUI application - does not own files or directories owned by other packages ==== MUST FIX ==== - Package must meet packaging naming guidelines, rename package to: php-pear-PHP-CodeSniffer - Rename %{name} accordingly - Package must own all directories it creates: change %{pear_phpdir}/PHP/* to %{pear_phpdir}/PHP in %files ==== SHOULD FIX ==== - URL should not contain a macro as it is copy&pasted from spec file by maintainers on a regular basis - Add versioned Requires: php > 5.1.0 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review