[Bug 768286] Review Request: libskk - Library to deal with Japanese kana-to-kanji conversion method

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=768286

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade@xxxxxxxxx
         AssignedTo|nobody@xxxxxxxxxxxxxxxxx    |panemade@xxxxxxxxx
               Flag|                            |fedora-review+

--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> 2011-12-19 05:47:01 EST ---
Review:-

+ koji scratch build for f17->
http://koji.fedoraproject.org/koji/taskinfo?taskID=3588356

+ rpmlint on rpms gave 
libskk.src: W: spelling-error Summary(en_US) kana -> Sana, Lana, Dana
libskk.src: W: spelling-error Summary(en_US) kanji -> Kantian
libskk.src: W: spelling-error %description -l en_US romaji -> Romania
libskk.src: W: spelling-error %description -l en_US kana -> Sana, Lana, Dana
libskk.x86_64: W: spelling-error Summary(en_US) kana -> Sana, Lana, Dana
libskk.x86_64: W: spelling-error Summary(en_US) kanji -> Kantian
libskk.x86_64: W: spelling-error %description -l en_US kana -> Sana, Lana, Dana
libskk.x86_64: W: spelling-error %description -l en_US kanji -> Kantian
libskk.x86_64: W: spelling-error %description -l en_US romaji -> Romania
libskk.x86_64: E: description-line-too-long C kana-kanji conversion algorithms,
based on GObject.  Currently it supports SKK (Simple
libskk.x86_64: E: description-line-too-long C Kana Kanji) input method with
various typing rules including romaji-to-kana, AZIK, ACT, TUT-Code, T-Code, and
NICOLA.
libskk.x86_64: W: no-manual-page-for-binary skk
libskk-devel.x86_64: W: no-documentation
3 packages and 0 specfiles checked; 2 errors, 11 warnings.
==> Fix the description error

+ Source verified with upstream as (sha1sum)
cdf7faadd96c7c22ecaa529f39f102dc87e08af6  libskk-0.0.2.tar.gz
cdf7faadd96c7c22ecaa529f39f102dc87e08af6  ../SOURCES/libskk-0.0.2.tar.gz

+ rest looks ok.


suggestions
1) COPYING should be added to %doc
2) fix the rpmlint error.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]