[Bug 765625] Review Request: python-pymodbus - A Modbus Protocol Stack in Python

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=765625

Ankur Sinha <sanjay.ankur@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #2 from Ankur Sinha <sanjay.ankur@xxxxxxxxx> 2011-12-18 05:59:07 EST ---
Hello: 

REVIEW:

+ OK
- NA 
X ISSUE

+ Package meets naming and packaging guidelines
^^
Since the software name is prefixed with "py", you can drop the python and just
name it "pymodbus", but this is only a cosmetic issue and your choice.

+ Spec file matches base package name.
+ Spec has consistant macro usage.
+ Meets Packaging Guidelines.
+ License
+ License field in spec matches
X License file included in package
^^ 
Please request upstream to include a COPYING file. You can include a BSD
license file as SOURCE1 for the time being. 

+ Spec in American English
+ Spec is legible.
+ Sources match upstream md5sum:
[ankur@ankur SOURCES]$ md5sum pymodbus-0.9.0.tar.gz
../SPECS/pymodbus-0.9.0.tar.gz
ea3f3b23a443ee80975514b40f11ece4  pymodbus-0.9.0.tar.gz
ea3f3b23a443ee80975514b40f11ece4  ../SPECS/pymodbus-0.9.0.tar.gz


- Package needs ExcludeArch
+ BuildRequires correct
- Spec handles locales/find_lang
- Package is relocatable and has a reason to be.
+ Package has %defattr and permissions on files is good.
+ Package is code or permissible content.
- Doc subpackage needed/used.
X Packages %doc files don't affect runtime.
^^
No documentation at all.

- Headers/static libs in -devel subpackage.
- Spec has needed ldconfig in post and postun
- .pc files in -devel subpackage/requires pkgconfig
- .so files in -devel subpackage.
- -devel package Requires: %{name} = %{version}-%{release}
- .la files are removed.

- Package is a GUI app and has a .desktop file

+ Package compiles and builds on at least one arch.
+ Package has no duplicate files in %files.
+ Package doesn't own any directories other packages own.
+ Package owns all the directories it creates.
+ No rpmlint output.
[ankur@ankur SRPMS]$ rpmlint  python-pymodbus-0.9.0-1.fc16.src.rpm
../RPMS/noarch/python-pymodbus-0.9.0-1.fc16.noarch.rpm
../SPECS/python-pymodbus.spec
python-pymodbus.src: W: spelling-error %description -l en_US redis -> rides,
redid, reds
python-pymodbus.noarch: W: spelling-error %description -l en_US redis -> rides,
redid, reds
python-pymodbus.noarch: W: no-documentation
2 packages and 1 specfiles checked; 0 errors, 3 warnings.
[ankur@ankur SRPMS]$


+ final provides and requires are sane:
(include output of for i in *rpm; do echo $i; rpm -qp --provides $i; echo =;
rpm -qp --requires $i; echo;)
[ankur@ankur pymodbus]$ review-req-check
== python-pymodbus-0.9.0-1.fc16.noarch.rpm ==
Provides:
python-pymodbus = 0.9.0-1.fc16

Requires:
pyserial >= 2.4
python(abi) = 2.7
python-nose >= 0.9.3
python-twisted >= 2.5.0

== python-pymodbus-0.9.0-1.fc16.src.rpm ==
Provides:

Requires:
python2-devel
python-setuptools-devel


SHOULD Items:

+ Should build in mock.
+ Should build on all supported archs
- Should function as described.
- Should have sane scriptlets.
- Should have subpackages require base package with fully versioned depend.
+ Should have dist tag
- Should package latest version
- check for outstanding bugs on package. (For core merge reviews)

Issues:

1. Please request upstream to add a COPYING file. Some documentation would be
nice too.
2. Please do convert the spec to python3 compatible as Jochen requests. Do also
have a dialogue with upstream on whether the module is python3 compatible or
not. 


No blockers at all.

XXX APPROVED XXX

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]