Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710904 --- Comment #7 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2011-12-17 04:39:59 EST --- Does not build: Making dvi comms.dvi /bin/sh: line 4: texi2dvi: command not found make: *** [comms.dvi] Error 127 Adding BR /usr/bin/texi2dvi fixes this problem. ** BuildRequires: octave-devel octave-signal >= 1.0.0 octave-image >= 0.0.0 hdf5-devel is somewhat complicated. I would prefer the BRs once per line, especially if you state EVR requirements. ** Please take a habit of preserving permissions while copying sources, e.g. cp -p %{SOURCE1} %{SOURCE2} . Also, if you give executable rights to the source files, you don't need to run chmod in the spec. ** You do know that pushd doc make popd can be written simply as make -C doc ** Please get rid of the %attr lines, they shouldn't be necessary. ** Didn't you file a bug against octave for the octave_cmd bit not working? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review