Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=752311 Mohamed El Morabity <pikachu.2014@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |pikachu.2014@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |pikachu.2014@xxxxxxxxx Flag| |fedora-review? --- Comment #1 from Mohamed El Morabity <pikachu.2014@xxxxxxxxx> 2011-12-16 07:39:07 EST --- Some comments: * You don't need to define the %python_sitelib macro, it is already defined by default (see the /usr/lib/rpm/macros file): http://fedoraproject.org/wiki/Packaging:Python#Macros * I don't really think python-devel is needed to build your package. * Since python and wxGTK are already required by wxPython, you can remove these two packages from the Requires. * Do you really think gitso modules need to be installed in %{python_sitelib}/%{name} ? These files are not inteded to be visible from Python. You should install them in %{_datadir}/%{name}, as done by upstream. * Why did you remove the MimeType key in the .desktop file? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review