Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=753016 Tom Hughes <tom@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |tom@xxxxxxxxxx Flag| |fedora-review? --- Comment #1 from Tom Hughes <tom@xxxxxxxxxx> 2011-12-16 06:23:35 EST --- Initial review comments: MUST License field in the package spec file matches the actual license gcr/icons/render-icons.py is LGPLv3 / CC-BY-SA 3.0 gcr/gcr-menu-button.c is GPLv2 gcr/gcr-collection-model.c is GPLv2 gcr/gcr-collection-model.h is GPLv2 gck/pkcs11n.h is MPLv1.1 MUST Rpmlint output is silent gcr.x86_64: E: incorrect-fsf-address /usr/share/doc/gcr-3.3.1/COPYING gcr.x86_64: W: no-manual-page-for-binary gcr-viewer gcr-devel.x86_64: E: incorrect-fsf-address /usr/include/gcr-3/gcr/gcr-key-widget.h [ repeated for many other header files ] gcr-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gcr-3.3.1/gcr/gcr-unlock-options-widget.h [ repeated for many other source files ] SHOULD Patches link to upstream bugs/comments/lists or are otherwise justified No explanation for gcr-fix.patch -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review