[Bug 759712] Review Request: dragonegg - GCC plugin to use LLVM optimizers and code generators

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=759712

--- Comment #2 from Jerry James <loganjerry@xxxxxxxxx> 2011-12-15 17:55:56 EST ---
I tried to build this on a rawhide machine, and got this:
...
+ make -j3
Compiling utils/TargetInfo.cpp
g++: error: directory": No such file or directory
make: *** [TargetInfo.o] Error 1
error: Bad exit status from /var/tmp/rpm-tmp.itjbTr (%build)

Building with "make VERBOSE=1" shows that the g++ invocation includes this:
-DREVISION=\"Unversioned directory\".  The shell sees that as two words:
  -DREVISION=\"Unversioned
  directory\"

REVISION is set to that value by svnversion.  So this package cannot be built
on a machine where svnversion is installed.

In mock, on the other hand, the build succeeds, since nothing pulls in
svnversion, but I see this in the logs:
make: svnversion: Command not found

It looks like REVISION is only used in one source file, src/Backend.cpp, and
that the code that uses it is only compiled if IDENT_ASM_OP is defined, and
that nothing defines IDENT_ASM_OP.  So I did this in %prep:

sed -i "s/^REVISION:=.*/REVISION:=%{version}/" Makefile

What do you think?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]