Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=766916 --- Comment #1 from Jeff Ortel <jortel@xxxxxxxxxx> 2011-12-15 16:49:27 EST --- Hey John, Looks pretty good. Few minor things so far: * Replace: %define with: %global per packaging guidelines 1.32. * The %description: A tool for syncing content from the Red Hat Network. Does not seem to accurately and completely describe the package. * Source0: https://fedorahosted.org/releases/g/r/%{name}/%{name}-%{version}.tar.gz looking for: grinder-0.132.tar.gz in: https://fedorahosted.org/releases/g/r/grinder does not match: grinder-0.0.132.tar.gz found instead. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review