Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=718681 Scott Tsai <scottt.tw@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |scottt.tw@xxxxxxxxx --- Comment #16 from Scott Tsai <scottt.tw@xxxxxxxxx> 2011-12-13 19:18:38 EST --- Informal review. I also can't sponsor people in Fedora. 1. Specify URL of Patch0 like this: - Patch0: beta8_hotfix1.patch + Patch0: http://luajit.org/download/beta8_hotfix1.patch - Source1: http://luajit.org/download/beta8_hotfix1.patch 2. Rename /usr/bin/luajit-2.0.0-beta8 to /usr/bin/luajit The main command is only installed as: /usr/bin/luajit-2.0.0-beta8 having the 'luajit' binary name change from under the user as we update to newer beta releases seems clearly undesirable. Quoting from upstream http://luajit.org/install.html: "to avoid overwriting a previous version, the beta test releases only install the LuaJIT executable under the versioned name (i.e. luajit-2.0.0-beta8). You probably want to create a symlink for convenience ..." Since we're not packaging multiple versions of luajit in Fedora at this time, I recommend you simply rename the binary as /usr/bin/luajit This would also get rid of the "no-manual-page-for-binary" rpmlint warning. 3. Make up your mind on whether to support older rpmb versions If support for EPEL5 is desired, then the -devel package should require pkgconfig. Otherwise we can rely on newer rpm features and remove BuildRoot and "rm -rf %{buildroot}" from the spec. Other comments: I ran the small collection of Lua 5.1 tests from http://testmore.luaforge.net/ and they worked. Regarding libluajit calling exit, I did a quick scan of the source and besides implementing os.exit() luajit may also call exit() during exception handling errors (lj_err.c). rpmlint complaining about shared libraries calling exit seems to be codifying a policy that's not universally applicable in the wrong place anyway. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review