Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=767185 Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tomspur@xxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #2 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2011-12-13 18:58:10 EST --- Review: - rpmlint ok $ rpmlint /home/tom/rpmbuild/SRPMS/pygtkhelpers-0.4.2-3.fc16.src.rpm /home/tom/rpmbuild/RPMS/noarch/pygtkhelpers-0.4.2-3.fc16.noarch.rpm /home/tom/rpmbuild/RPMS/noarch/pygtkhelpers-examples-0.4.2-3.fc16.noarch.rpm pygtkhelpers.src: W: spelling-error %description -l en_US frameworky -> framework, frameworks, framework y pygtkhelpers.noarch: W: spelling-error %description -l en_US frameworky -> framework, frameworks, framework y 3 packages and 0 specfiles checked; 0 errors, 2 warnings. - macros everywhere - no libs - no .la NEEDSWORK - A %check won't work, because you can't import gtk in the buildsystem so anything will fail here. But running the tests locally, most things fails anyway. Could you test this with pida, so you are sure, this package works at all? (It looks they are only using a different nose abi than current f16, so changes are good. ;)) - license: from AUTHORS.txt: "pygtkhelpers.utils.gsignal/gproperty are taken from kiwi" Kiwi is LGPLv2+ (according to yum info python-kiwi), so LGPLv3 is allowed ./pygtkhelpers/debug/console.py is also LGPLed from medit, so LGPLv3 is ok too (Both seem to be adopted here, so I don't think they count as bundled lib... What's your opinion here?) - R not good. Python requires aren't automatic (yet?), so at least pygtk, pango and ***flatland***: ./pygtkhelpers/forms.py:from flatland import Dict, String, Integer, Boolean Couldn't find flatland in fedora yet... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review