Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=756443 --- Comment #3 from Juan Orti Alcaine <j.orti.alcaine@xxxxxxxxx> 2011-12-13 16:45:20 EST --- (In reply to comment #1) Hello, I have updated the package, the new files are here: Spec URL: https://raw.github.com/jorti/cagraph-fedora-package/v1.2-8/SPECS/python-cagraph.spec SRPM URL: https://github.com/jorti/cagraph-fedora-package/raw/v1.2-8/SRPMS/python-cagraph-1.2-8.fc16.src.rpm > According to the files, license is GPLv3+, not GPLv3 Fixed. > rm -rf %{buildroot}/*, clean section and buildroot definition are not > necessary, if you're not aiming for EPEL 5: > http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#BuildRoot_tag I would like to be able to compile it for EPEL, because this library is used by tor-arm, a monitor for Tor routers which I also submited to review in bug #756445 > The if clause for Suse is no use in Fedora. I guess you're trying to keep a > single spec for Suse and Fedora. I don't know Suse's guidelines, but that might > not work. All references to Suse removed. > Don't install the documentation on your own. Only use %doc in the files > section: http://fedoraproject.org/wiki/Packaging:Guidelines#Documentation Fixed. > FSF postal address is wrong: Fixed. I include a patch and also submitted it upstream > I think this package should have "python" in the name: > http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_.28python_modules.29 Renamed. > I suppose you can use a single chmod to change all the py file's permissions. Done. Now the output of rpmlint is clean: $ rpmlint SPECS/python-cagraph.spec RPMS/noarch/python-cagraph-1.2-8.fc16.noarch.rpm SRPMS/python-cagraph-1.2-8.fc16.src.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review