Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=695022 --- Comment #12 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2011-12-13 08:41:17 EST --- (In reply to comment #11) > Ping? I'd really like to fix PIDA. . . This looks stalled. How about requesting a new review and closing this as a duplicate of the new one, Jon? (In reply to comment #0) > Spec URL: > http://lzap.fedorapeople.org/fedora-packaging/pygtkhelpers/0.4.2-1/pygtkhelpers.spec Looks ok without having a deeper look. Some comments: - R: on a hardcoded python version is bad. The R on the python(abi) is added automatically anyway, so leaving it out would be the best... - There is no BuildRoot defined, but %clean and rm -rf in %install. All is needed for builting in el5 and nothing is needed in Fedora, so you can choose what to do here. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review