Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674008 --- Comment #69 from Rosen Diankov <rosen.diankov@xxxxxxxxx> 2011-12-13 08:38:54 EST --- hi tim, sorry for the confusion, the latest_stable are the release candidates, and are in constant flux. the last official release is 0.4.2. should i write something on the webpage to avoid this confusion? Your patches look good except: 1. why did you remove the relpath being called? this is necessary on ubuntu systems. COMMAND ${PYTHON_EXECUTABLE} -c "from distutils.sysconfig import get_python_lib; from os.path import relpath; print relpath(get_python_lib(1,prefix='${CMAKE_INSTALL_PREFIX}'),'${CMAKE_INSTALL_PREFIX}')" 2. openrave.pc is not supposed to link with libopenrave-core.so. Plugin authors only need to link with libopenrave.so. I think what you are looking for is openrave-core.pc, do you want to output it? 3. i would like to rename OPENRAVE_INCLUDE_DIRNAME to OPENRAVE_INCLUDE_DIR. 4. config.h.in, you removed CMAKE_INSTALL_PREFIX. what were your reasons? unfortunately this is needed or openrave will not be able to find the default plugin/data directories. 5. as for the boost changes, i think we had those fixed on the recent trunk. from a quick glance, it looks like the current openrave trunk should compile fine for you.. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review