Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=728815 Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tomspur@xxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #4 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2011-12-12 16:07:12 EST --- (In reply to comment #3) > (In reply to comment #2) > > Hmm, you might need to port this to a new soci version > > In fact, I am also the maintainer of SOCI :) Hmm, problem solved ;) REVIEW: - your favorite, (ignorable in your case) rpmlint error: ;) $ rpmlint /home/tom/rpmbuild/RPMS/x86_64/trademgen-0.2.1-1.fc16.x86_64.rpm /home/tom/rpmbuild/RPMS/x86_64/trademgen-devel-0.2.1-1.fc16.x86_64.rpm /home/tom/rpmbuild/RPMS/x86_64/trademgen-debuginfo-0.2.1-1.fc16.x86_64.rpm /home/tom/rpmbuild/RPMS/noarch/trademgen-doc-0.2.1-1.fc16.noarch.rpm /home/tom/rpmbuild/SRPMS/trademgen-0.2.1-1.fc16.src.rpm trademgen.src: E: invalid-spec-name 5 packages and 0 specfiles checked; 1 errors, 0 warnings. - name ok - doc noarch properly - el5 needs there (buildroot & R pkgconfig) - libraries correctly packaged - ldconfig there - check there - parallel make - macros everywhere - %doc ok - koji successful: http://koji.fedoraproject.org/koji/taskinfo?taskID=3580978 NEEDSWORK: - The python lib doesn't seem to work or pytrademgen has a UserError (Maybe write an test for it? ;)): $ pytrademgen FRA searchString: FRA Raw result from the Trademgen library: The Trademgen service has not been initialised, i.e., the init() method has not been called correctly on the Trademgener object. Please check that all the parameters are not empty and point to actual files. - license looks weired - It looks like Boost is bundled for running the tests: ./test/math/boost_math/empirical_distribution/count.hpp: BSL (v1.0) ./test/math/boost_math/empirical_distribution/frequency.hpp: BSL (v1.0) ./test/math/boost_math/empirical_distribution/ordered_sample.hpp: BSL (v1.0) But I can't find those files in boost-devel. If they are not needed besides the tests, it should be ok, but grepping for it: $ find | xargs grep functors.hpp ./test/math/boost_math/visualization/boost/svg_plot/detail/functors.hpp:// functors.hpp ./test/math/boost_math/visualization/boost/svg_plot/svg_1d_plot.hpp:#include "detail/functors.hpp" ./test/math/boost_math/visualization/boost/svg_plot/svg_boxplot.hpp:#include "detail/functors.hpp" ./test/math/boost_math/visualization/boost/svg_plot/svg_2d_plot.hpp:#include "detail/functors.hpp" Binary file ./trademgen/libtrademgen.so.0.2.1 matches Binary file ./trademgen/CMakeFiles/trademgenlib.dir/command/DemandManager.cpp.o matches Binary file ./trademgen/libtrademgen.so.0.2 matches Binary file ./trademgen/libtrademgen.so matches and $ locate functors.hpp /usr/include/boost/date_time/adjust_functors.hpp /usr/include/boost/icl/functors.hpp /usr/include/boost/lambda/detail/lambda_functors.hpp I'm unsure, where this dependency comes from, it just looks like the tests might be used in linking (after simply deleting tests cmake . doesn't complete...) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review