Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=766604 Cédric OLIVIER <cedric.olivier@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cedric.olivier@xxxxxxx --- Comment #1 from Cédric OLIVIER <cedric.olivier@xxxxxxx> 2011-12-12 13:35:02 EST --- * Could you move %defattr at the top of %files (it's a cosmetic change, but %defattr tends to be used at the top of %files) * Could you remove #Requires comments * Could you remove "bash" build requires dependencies and add udisks(http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2) For URL project page, http://sourceforge.net/projects/bashmount/ seems to be more complete than https://gitorious.org/bashmount/bashmount -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review