Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=766083 --- Comment #3 from MERCIER Jonathan <bioinfornatics@xxxxxxxxx> 2011-12-11 06:53:24 EST --- (In reply to comment #2) > Hello, > some remarks: > > - you can remove %defattr section at the beginning of each %file section > https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions Done > - "Group:" spécification is useless too, so you can remove it Done > - If you plan to build this package for EPEL < 6, ignore following remarks: > - you can remove %clean section > https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean Done > - you can remove "rm -rf %{buildroot}" at the beginning of %install section Done > - I found a difference between the spec file in attachement of this review > request and the spec file uploaded on your fedorapeople(that is the same as > the spec file in the srpm) > > $ diff derelict.spec derelict.spec.bak > 22,23c22,24 > < BuildRequires: ldc, ldc-phobos-devel, ldc-druntime-devel > < Requires: ldc-phobos-devel, ldc-druntime-devel > --- > > BuildRequires: ldc > > BuildRequires: ldc-phobos > > Requires: ldc-phobos > > Please update accordingly changelog section Done srpm and spec updated: - http://bioinfornatics.fedorapeople.org/derelict.spec - http://bioinfornatics.fedorapeople.org/derelict-2-13.20111031svn591.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review