Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=759747 Volker Fröhlich <volker27@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |volker27@xxxxxx --- Comment #1 from Volker Fröhlich <volker27@xxxxxx> 2011-12-08 20:42:31 EST --- * Doesn't build on my machine: "src/pycms/_pycms.c:21:18: fatal error: lcms.h: No such file or directory" * The tarball seems to bundle a couple of other Python modules. They should be removed in the prep section. * You can drop "-n sk1libs-%{version}", as it's the default. * Defattr is no longer necessary * Defining python_sitearch is not necessary for Fedora anymore. If you're going for EPEL 5, it is necessary, but only for EPEL: http://fedoraproject.org/wiki/Packaging:Python#Macros Drop the clean section and the rm in the install section in that case. Otherwise define buildroot: http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#BuildRoot_tag -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review