Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=759855 Volker Fröhlich <volker27@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |volker27@xxxxxx --- Comment #4 from Volker Fröhlich <volker27@xxxxxx> 2011-12-08 20:26:36 EST --- * License is GPLv2+, not GPL * Please put Name before Summary * You can use the name macro in Source0 * If you're not out for EPEL 5, you can drop buildroot, clean section and the rm in the install section, see: http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#BuildRoot_tag * Include the README file using %doc * Don't gzip the man page on your own, rpmbuild takes care of it. * Drop defattr and correct permissions in the install section, if necessary * I suppose, you'll need to follow the guidelines for systemd: http://fedoraproject.org/wiki/Packaging:Systemd * %{_sysconfdir}/sysconfig/sslh -- Really? * Use the optflags: http://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags [makerpm@desktop SPECS]$ rpmlint /home/makerpm/rpmbuild/RPMS/x86_64/sslh-1.10-1.fc16.x86_64.rpm sslh.x86_64: W: spelling-error Summary(en_US) ssl -> isl, sol, ssh sslh.x86_64: W: summary-not-capitalized C ssl/ssh multiplexer sslh.x86_64: W: invalid-license GPL sslh.x86_64: W: conffile-without-noreplace-flag /etc/rc.d/init.d/sslh sslh.x86_64: E: executable-marked-as-config-file /etc/rc.d/init.d/sslh sslh.x86_64: W: service-default-enabled /etc/rc.d/init.d/sslh sslh.x86_64: W: no-reload-entry /etc/rc.d/init.d/sslh sslh.x86_64: E: subsys-not-used /etc/rc.d/init.d/sslh 1 packages and 0 specfiles checked; 2 errors, 6 warnings. [makerpm@desktop SPECS]$ rpmlint /home/makerpm/rpmbuild/RPMS/x86_64/sslh-debuginfo-1.10-1.fc16.x86_64.rpm sslh-debuginfo.x86_64: W: invalid-license GPL sslh-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/sslh-1.10/common.h sslh-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/sslh-1.10/common.c 1 packages and 0 specfiles checked; 0 errors, 3 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review