Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755890 --- Comment #19 from Richard Shaw <hobbes1069@xxxxxxxxx> 2011-12-08 11:51:06 EST --- Ok, last question I hope until I do the full guideline checks... How did you include the fix? I was looking for a "Patch0: ..." and "%patch0 ..." in the spec file but it's not there. Also, I noticed you're using github. I'm not a git expert but I've noticed other projects use the tags for released versions, so in your case I would expect to see a 0.5.0 release tagged, then you would generate a patch. For instance, if you created a tag "snap-0.5.0" you could use something like: git diff -p --stat snap-0.5.0 7a53119b1d5bd048a4ddfbdf5bf9962f3d5699dc > snap-snapfile.patch Of course, do it first without the ">" so you can make sure it's what you meant. If you've already included the fix, maybe just bump the patch rev and call it 0.5.1. Then you would reset your "Release:" tag back to 1 (but keep all the changelog history) Richard -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review