Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=749299 --- Comment #13 from Ricardo Rocha <rocha.porto@xxxxxxxxx> 2011-12-08 06:09:12 EST --- Hi. (In reply to comment #11) > Hi, > The explicit > > %if %{?fedora}%{!?fedora:0} >= 10 || %{?rhel}%{!?rhel:0} >= 6 > BuildRequires: libcurl-devel > %else > BuildRequires: curl-devel > %endif > > on devel package is not needed, it's there on the main package which > is good enough. Removed. > Regarding the static html files > > /var/www/css > /var/www/css/lcgdm-dav.css > /var/www/icons > /var/www/icons/dpm20.png > > these are a web application so move them to > > /usr/share/lcgdm-dav > > and update alias to use them. > > http://fedoraproject.org/wiki/Packaging:Guidelines#Web_Applications In fact they were there before, i just thought it would be better in /var/www (should have double checked the guidelines). Moved to /usr/share/lcgdm-dav as suggested. > Also the httpd configuration takes of the web server with > > <Location /> > DAV dpm > </Location> > > so now everything is dpmdav regardless of what else is installed. > > could this be restricted to some default path prefix? Changed to: <Location /dpm> DAVBase /dpm which only enables the app for /dpm paths, and add /dpm to any relative path so that we build the full DPM namespace when contacting the nameserver. It works... the only disadvantage is that you can only start the listing from /dpm, you cannot list / anymore - not very serious though, as /dpm is mandated for all installations. > Also the configuration contains: > > ProxyCache /var/proxycache > > this directory does not exist but more importantly it if is needed > it should be in /var/lib/lcgdpm-dav or something. This is hard-coded in the gridsite delegation cgi, nothing we can do about it (i can submit a bug though). This is an optional feature though, it won't be used if no gridsite-delegation is installed. In addition: - scriplets reload httpd now - modules are loaded conditionally But for the modules even conditional loading is not perfect, as for example SSL is loaded by lcgdm-dav (triggered first and it has to be there for the lcgdm-dav provider to be able to load), but ssl.conf does not conditionally load, so you still get the warning. I don't think renaming the conf file to zlcgdm-dav.conf is a very good idea to prevent this - other people would do the same and it wouldn't look very nice. New spec and src rpm: http://rocha.web.cern.ch/rocha/fedora/lcgdm-dav.spec http://rocha.web.cern.ch/rocha/fedora/lcgdm-dav-0.5.3-1.src.rpm Koji builds as soon as koji works again. Thanks, Ricardo -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review