Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=755890 --- Comment #15 from Richard Shaw <hobbes1069@xxxxxxxxx> 2011-12-07 17:19:33 EST --- Ack! Sorry I keep finding stuff :) 1. There's no documentation in the main package. I would include a line like this, with our without the PDF depending on if it's relevant: %files %doc CHANGELOG LICENSE README docs/paper.pdf ... rest of %files section ... 2. Do we need python2 if we're building with python3? If not change your BuildRequires to: %if 0%{?with_python3} BuildRequires: python3-devel %else BuildRequires: python2-devel %endif # if with_python3 Richard -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review