Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=760177 Aleksandra Bookwar <alpha@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alpha@xxxxxxxxxxxx --- Comment #1 from Aleksandra Bookwar <alpha@xxxxxxxxxxxx> 2011-12-06 17:34:19 EST --- I am not a packager myself, so here are just some comments. Hope they help. * First of all you should run the "rpmlint -i" command on both spec-file and rpm. There are several issues which need to be fixed according to the http://fedoraproject.org/wiki/Packaging/Guidelines $ rpmlint rpmbuild/SPECS/knot.spec rpmbuild/SPECS/knot.spec:6: W: non-standard-group Networking/Daemons rpmbuild/SPECS/knot.spec:19: W: setup-not-quiet rpmbuild/SPECS/knot.spec:22: W: configure-without-libdir-spec rpmbuild/SPECS/knot.spec:29: E: hardcoded-library-path in %{buildroot}/lib/systemd/system/ rpmbuild/SPECS/knot.spec:30: E: use-of-RPM_SOURCE_DIR rpmbuild/SPECS/knot.spec:30: E: hardcoded-library-path in %{buildroot}/lib/systemd/system/%{name}.service rpmbuild/SPECS/knot.spec:41: E: hardcoded-library-path in /lib/systemd/system/%{name}.service 0 packages and 1 specfiles checked; 4 errors, 3 warnings. $ rpmlint knot-0.8.1-1.fc16.x86_64.rpm knot.x86_64: W: name-repeated-in-summary C KNOT knot.x86_64: W: non-standard-group Networking/Daemons knot.x86_64: W: invalid-license GPL knot.x86_64: W: conffile-without-noreplace-flag /etc/knot/knot.sample.conf knot.x86_64: W: conffile-without-noreplace-flag /etc/knot/example.com.zone knot.x86_64: W: one-line-command-in-%post /sbin/ldconfig 1 packages and 0 specfiles checked; 0 errors, 6 warnings * Use %{SOURCE1} instead of $RPM_SOURCE_DIR/%{name}.service http://fedoraproject.org/wiki/Packaging:RPM_Source_Dir * You need better handling for the systemd unit. Check the http://fedoraproject.org/wiki/Packaging:Systemd#Filesystem_locations for %{_unitdir} and ScripletSnippets. * Source tag needs to be Source0 * ldconfig needs to be called twice in %post and %postun sections http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries * man pages do not go into %docs, they should be installed explicitly * You do not need to set BuildRoot tag explicitly anymore * %defattr is not needed also, since it is the default * systemd unit should not be marked as %config -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review