[Bug 760357] Review Request: rubygem-systemu - Universal capture of stdout and stderr and handling of child process pid

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=760357

Steve Traylen <steve.traylen@xxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |steve.traylen@xxxxxxx
         AssignedTo|nobody@xxxxxxxxxxxxxxxxx    |steve.traylen@xxxxxxx

--- Comment #1 from Steve Traylen <steve.traylen@xxxxxxx> 2011-12-06 09:58:18 EST ---
Hi,
You have a type 

rm -rf %{_buildroot}

should of course be 

rm -rf %{buildroot}


Otherwise this looks like a text book rubygem package as described on 
http://fedoraproject.org/wiki/Packaging:Ruby 

I have issues with the ruby guidelines but they are what they are so we follow
them:

Checksums match.

$ md5sum systemu-2.4.1.gem ../SOURCES/systemu-2.4.1.gem 
c95eb1dd231cac73b11224a9d3ee35c2  systemu-2.4.1.gem
c95eb1dd231cac73b11224a9d3ee35c2  ../SOURCES/systemu-2.4.1.gem


License is marked with 'Ruby or GPLv2' and this is clearly correct.

same as Ruby's

http://www.ruby-lang.org/en/LICENSE.txt

is contained within the LICENSE.txt file.

rubygem-systemu.noarch: W: spelling-error Summary(en_US) stdout -> stout, std
out, std-out
rubygem-systemu.noarch: W: spelling-error Summary(en_US) stderr -> std err,
std-err, stander
rubygem-systemu.noarch: W: spelling-error Summary(en_US) pid -> peed, dip, pud

which are all fine.

rubygem-systemu.noarch: W: non-standard-group Unspecified

rubygem-systemu.src: W: non-standard-group Unspecified
rubygem-systemu.src: W: no-cleaning-of-buildroot %install
2 packages and 1 specfiles checked; 0 errors, 16 warnings.


So please add a group and correct the _buildroot macro and I think it is there.

Steve.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]