Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=749299 --- Comment #9 from Ricardo Rocha <rocha.porto@xxxxxxxxx> 2011-12-06 05:49:48 EST --- Hi. Thanks for the checks, see below. (In reply to comment #6) > OLD: > > Just to summarize what is left from above to be resolved: > > The -devel package has scriptlets of > > postinstall program: /sbin/ldconfig > postuninstall program: /sbin/ldconfig > > and I think it should not despite containing a .so file. I need to look some > more. Fixed. I still read it the other way from time to time in the guidelines - i'm not a native speaker, but the "(not just symlinks)" part looks confusing. > > NEW: > > lcgdm-dav-0.5.1-1.el6.x86_64 requires ' liblcgdmhtext.so.0()(64bit)' only. > but not 'lcgdm-dav-libs' > > Please add a > > Requires: lcgdm-dav-libs = %{version}-%{release}%{?isa} > > explicitly, check for others, e.g devel probably requires libs. Inter package > dependencies should be exact and not rely on autorequires. The last thing you > want is some hybrid of versions out there in the wild. Done for server and client, devel had it already. > Now something that seems conceptually odd to me? > > /etc/rc.d/init.d/lcgdm-dav > > appears to run standard httpd with a custom configuration. This is a new > concept to me, I have not see else where. > > Having multiple start up scripts start up deamons in different ways seems odd? > Why is this not just a virtual host configuration in /etc/httpd/conf.d? It's > essentially a web site/application isn't it? Sorry about this, it was a left over from a previous version of the package. Fixed now to have a lcgdm-dav.conf in conf.d as it should be. Other changes made: - added man page for htcopy tool (a small wrapper around libcurl for multi stream transfers, credential delegation, third party copies, etc) - added missing dependency on mod_ssl - changed preun/postun to handle httpd (please double check if it's the correct way though, stop on preun, condrestart on postun) Thanks. New srpm/spec: http://rocha.web.cern.ch/rocha/fedora/lcgdm-dav.spec http://rocha.web.cern.ch/rocha/fedora/lcgdm-dav-0.5.2-1.src.rpm koji builds (success): https://koji.fedoraproject.org/koji/taskinfo?taskID=3569404 (5E) https://koji.fedoraproject.org/koji/taskinfo?taskID=3569408 (6E) https://koji.fedoraproject.org/koji/taskinfo?taskID=3569412 (F16) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review