Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=742610 --- Comment #8 from Orion Poplawski <orion@xxxxxxxxxxxxx> 2011-12-05 16:48:51 EST --- (In reply to comment #6) > • A few notes: > ∘ Isn't there any documentation for this library? There is an info file. I've added examples and the pdf version to the -devel %doc as well. > ∘ calling exit might be solvable talking to upstream This is a legacy library that is only around for compatibility, so no real changes are going to be made. > ∘ 'libs' might be replaced by 'libraries' Done. > • A few notes > ∘ consider removing %defattr > (http://fedoraproject.org/wiki/Packaging/Guidelines#File_Permissions) > ∘ consider removing %clean > (http://fedoraproject.org/wiki/Packaging/Guidelines#.25clean) > ∘ consider removing the buildroot tag > (http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag) Done New Package SCM Request ======================= Package Name: netcdf-cxx Short Description: Legacy netCDF C++ library Owners: orion Branches: InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review