Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=760045 Haïkel Guémar <karlthered@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |karlthered@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |karlthered@xxxxxxxxx --- Comment #2 from Haïkel Guémar <karlthered@xxxxxxxxx> 2011-12-05 18:02:57 EST --- 1. did you rename upstream tarball ? if so, please do not. I suggest you advise upstream to generate more downstream suitable tarball (<name>-<version>) using more efficient compression schemes like bz2 or xz. 2. upstream states that you should not use pystatgrab < 0.5, please fix the requirements accordingly 3. use %global instead of hardcoding upstream tarball name (nico-largo), upstream hash (09cc4df), that's a bad habit since they will likely change in the future 4. use singular instead of plural in both Summary and description since glances provide only one tool (you should tell upstream too) 5. i suggest that you rename the command-line to glances, less confusing for users than glances.py. 6. about the " non-executable-script" rpmlint error, i suggest that yo u remove the shebang on /usr/lib/python2.7/site-packages/glances/glances.py, for instance: sed -i '1d' %{python_sitelib}/%{name}/%{name}.py 7. i suggest that you ask upstream to provide a man page, that's a good pratice. Fix points 1 to 6, and we'll start formal review -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review