Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=759855 Aleksandra Bookwar <alpha@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alpha@xxxxxxxxxxxx --- Comment #2 from Aleksandra Bookwar <alpha@xxxxxxxxxxxx> 2011-12-05 07:29:45 EST --- I am not yet a packager myself, but I have some comments on the spec you've posted. 1) There is no need for _cc and _install macros in your spec files. http://fedoraproject.org/wiki/Packaging:Guidelines#Macros says: Macro forms of system executables SHOULD NOT be used except when there is a need to allow the location of those executables to be configurable. For example, rm should be used in preference to %{__rm}, but %{__python} is acceptable. 2) Fedora 15 and later use systemd. So you need to provide systemd unit instead of initscript. http://fedoraproject.org/wiki/Packaging:SysVInitScript#Initscripts_in_addition_to_systemd_unit_files 3) %clean section and %defattr no longer needed in the spec-files. And about %build section - isn't it better to have the proper Makefile in the upstream sources and use make and make install instead of explicit build rules? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review