[Bug 755510] Review Request: gnome-shell-extension-system-monitor-applet - Gnome shell system monitor extension

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=755510

--- Comment #5 from Alex Lancaster <alexl@xxxxxxxxxxxxxxxxxxxxx> 2011-12-03 14:24:18 EST ---
(In reply to comment #4)
> (In reply to comment #3)
> > Initial review, although this requires an official sponsor, and I am not one.
> 
> Thanks for the review.
> 
> > I'm not sure how to handle you having multiple srpms. I've done this review on
> > the Fedora 16 srpm
> > I thought one srpm should be able to build for 15 and 16.
> 
> Yes this should be done, but in this case sources are different and not
> compatible, so 2 srpm files were build with 2 different sources tarball files.
> Never mind, I've splitted the files in two independent sets of files: one for
> F-15 and one for F-16

Generally it's only necessary to review a single SRPM that's going into
rawhide.  It's assumed that the maintainer can make the necessary changes
(including using different versions) for packages that go into currently
maintained releases (in this case F15 and F16).  Having said that, it probably
doesn't do any harm to include the version for F15, but the reviewer should
base his or her review on the version going into rawhide.  (I assume that the
F16 and rawhide version will be the same).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]