Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: jamin - JACK Audio Mastering interface https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225114 green@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |green@xxxxxxxxxx ------- Additional Comments From green@xxxxxxxxxx 2007-01-29 10:50 EST ------- Hi Florin - thanks for submitting this. Here are some initial comments. * desktop_vendor is no longer planetccrma. * For Source0, can you please put the full URL to the tarball? * See the section "Handling Locale Files" in http://fedoraproject.org/wiki/Packaging/Guidelines We'll need to replace the "%{_datadir}/locale/*/LC_MESSAGES/jamin.mo" in %files with the find_lang stuff described in the wiki. Also... # rpmlint /usr/src/redhat/SRPMS/jamin-0.95.0-4.src.rpm W: jamin mixed-use-of-spaces-and-tabs (spaces: line 60, tab: line 1) I don't know where this is coming from. The spec file maybe? AG -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review