Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=713313 --- Comment #30 from Philip Prindeville <philipp@xxxxxxxxxxxxxxxxxxxxx> 2011-12-02 23:26:55 EST --- Some more observations: %if (0%{?rhel} && 0%{?rhel} <= 5) export KRB5_CONFIG="/usr/kerberos/bin/krb5-config" %else export KRB5_CONFIG="/usr/bin/krb5-config" %endif you handle RHEL and Fedora, but not EPEL or Centos... the conditionals can get pretty hairy to handle all of the permutations. Why not just have: if [ -x /usr/kerberos/bin/krb5-config ]; then export KRB5_CONFIG=/usr/kerberos/bin/krb5-config else export KRB5_CONFIG=/usr/bin/krb5-config fi instead. You could handle: %if (0%{?fedora} && 0%{?fedora} <= 16) || (0%{?rhel} && 0%{?rhel} <= 6) export CPPFLAGS="-I/usr/include/et/" %endif with a "if [ -d /usr/include/et ]; then" as well. Looking at: Requires: cyrus-sasl-gssapi is this strictly necessary? Rpm is usually pretty good about running 'ldd' on the generated objects and inferring dependencies. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review