Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=745510 Federico Simoncelli <fsimonce@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(rjones@xxxxxxxxxx | |) --- Comment #21 from Federico Simoncelli <fsimonce@xxxxxxxxxx> 2011-12-02 04:51:29 EST --- (In reply to comment #20) > Source0 hasn't been annotated as required, which is a reject. Sorry, I didn't notice Alan's comment. Spec URL: http://people.redhat.com/fsimonce/vdsm/vdsm.spec SRPM URL: http://people.redhat.com/fsimonce/vdsm/vdsm-4.9.1-2.git931a43e.fc16.src.rpm > There are still 8 rpmlint errors and 9 warnings. This is a lot, > albeit fewer than before. Please give a summary here of why > each rpmlint error and warning is not an actual error in the > spec file. The error and warning are mostly the rpmlint bugs that you pointed out in comment #16 anyway here's the summary: vdsm.src:290: E: hardcoded-library-path in %{buildroot}/lib/systemd/systemd-vdsmd vdsm.src:293: E: hardcoded-library-path in %{buildroot}/lib/systemd/systemd-vdsm-reg vdsm.src:430: E: hardcoded-library-path in /lib/systemd/systemd-vdsmd vdsm.src:685: E: hardcoded-library-path in /lib/systemd/systemd-vdsm-reg This is a rpmlint bug, it's present also in the systemd package: $ rpmlint systemd-36-3.fc16.src.rpm [...] systemd.src:262: E: hardcoded-library-path in /lib/systemd/systemd-* [...] vdsm.src: W: invalid-url Source0: vdsm-4.9.1-931a43e.tar.gz This was fixed by the vcs comment. vdsm.x86_64: E: non-readable /etc/sudoers.d/50_vdsm 0440L vdsm.x86_64: W: non-conffile-in-etc /etc/sudoers.d/50_vdsm vdsm.x86_64: E: non-readable /etc/pki/vdsm/keys/libvirt_password 0600L This is a rpmlint bug, sudoers shouldn't be readable and it's not configurable. The libvirt password shouldn't be readable. vdsm.x86_64: E: non-standard-dir-perm /var/lib/libvirt/qemu/channels 0775L VDSM needs the group to be able to write here. vdsm.x86_64: W: non-conffile-in-etc /etc/cron.d/vdsm-libvirt-logrotate vdsm-cli.noarch: W: non-conffile-in-etc /etc/bash_completion.d/vdsClient The logrotate and completion file aren't configurable. vdsm-debug-plugin.noarch: W: no-documentation No documentation upstream yet. vdsm-hook-faqemu.noarch: W: spelling-error Summary(en_US) qemu -> emu, q emu False positive spell checking. vdsm-hook-vhostmd.noarch: E: non-readable /etc/sudoers.d/50_vdsm_hook_vhostmd 0440L vdsm-hook-vhostmd.noarch: W: non-conffile-in-etc /etc/sudoers.d/50_vdsm_hook_vhostmd This is correct, see above. vdsm-reg.noarch: W: non-conffile-in-etc /etc/ovirt-commandline.d/vdsm-reg This is not configurable. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review