Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=753513 --- Comment #5 from Jon Ciesla <limb@xxxxxxxxxxxx> 2011-12-01 19:43:29 EST --- rpmlint: Some bogus spelling errors and: minetest.x86_64: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. Include the doc/ folder. minetest.x86_64: W: no-manual-page-for-binary minetest Each executable in standard binary directories should have a man page. minetest-server.x86_64: E: incoherent-logrotate-file /etc/logrotate.d/minetest Your logrotate file should be named /etc/logrotate.d/<package name>. Can this not match? minetest-server.x86_64: W: non-standard-uid /var/lib/minetest minetest A file in this package is owned by a non standard user. Standard users are: abrt, adm, amandabackup, apache, arpwatch, ats, avahi, avahi-autoipd, bacula, beagleindex, bin, clamav, condor, cyrus, daemon, dbus, desktop, distcache, dovecot, exim, fax, frontpage, ftp, games, gdm, glance, gopher, haldaemon, halt, hsqldb, ident, jonas, ldap, lp, luci, mail, mailman, mailnull, majordomo, mysql, named, netdump, news, nfsnobody, nobody, nocpulse, nova, nscd, nslcd, ntp, nut, operator, oprofile, ovirt, pegasus, piranha, pkiuser, polkituser, postfix, postgres, prelude-manager, privoxy, pulse, puppet, pvm, qemu, quagga, radiusd, radvd, retrace, rhevagent, rhevm, ricci, root, rpc, rpcuser, rpm, rtkit, sabayon, saned, shutdown, smmsp, snortd, squid, sshd, stap-server, swift, sync, tcpdump, tomcat, tss, usbmuxd, uucp, vcsa, vdsm, vhostmd, webalizer, wnn, xfs. minetest-server.x86_64: W: non-standard-gid /var/lib/minetest minetest A file in this package is owned by a non standard group. Standard groups are: abrt, adm, apache, arpwatch, ats, audio, avahi, avahi-autoipd, bacula, beagleindex, bin, cdrom, clamav, condor, console, daemon, dbus, desktop, dialout, dip, disk, distcache, dovecot, exim, fax, floppy, frontpage, ftp, games, gdm, glance, gopher, haldaemon, hsqldb, ident, jonas, kmem, kvm, ldap, lock, lp, luci, mail, mailman, mailnull, majordomo, man, mem, mysql, named, netdump, news, nfsnobody, nobody, nocpulse, nova, nscd, ntp, nut, oprofile, ovirt, pegasus, piranha, pkiuser, polkituser, popusers, postdrop, postfix, postgres, pppusers, prelude-manager, privoxy, pulse, puppet, pvm, qemu, quagga, quaggavt, radiusd, radvd, realtime, retrace, rhevagent, rhevm, ricci, root, rpc, rpcuser, rpm, rtkit, sabayon, saned, saslauth, screen, slipusers, slocate, smmsp, snortd, squid, sshd, stap-server, swift, sys, tape, tcpdump, tomcat, tss, tty, usbmuxd, users, utempter, utmp, uucp, vcsa, vhostmd, video, wbpriv, webalizer, wheel, wine, wnn, xfs. These two are probably OK. minetest-server.x86_64: W: no-manual-page-for-binary minetestserver Each executable in standard binary directories should have a man page. - package meets naming guidelines - package meets packaging guidelines I'd rather the Source0 end in tar.gz, to more clearly indicate its type. The celereon-minitest<foo> name from the download link is fine. You can also drop the git checkout info from the version, since it's a released version, not a checkout. - license ( GPLv2+ ) OK, text in %doc, matches source Include licence file, which you will when you include doc/ - spec file legible, in am. english - source matches upstream - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file Running a mock build to test BRs, though I think they're probably OK. So at present, it looks like you just need to include docs, fix the tarball name, and think about the logrotate filename. I'll post anything else I run across. When you do one or two practice reviews, post links here. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review