[Bug 758472] Review Request: Equalizer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=758472

--- Comment #10 from Stefan Eilemann <eilemann@xxxxxxxxx> 2011-12-01 05:43:59 EST ---
(In reply to comment #9)
> generally it is not good to use exit in lib. It shouldn't be blocker for this
> review, but would be possible to redesign this in the future?

Mhh, good question. Iirc ::exit is called in two places:

1) In Collage after a fork() in the child process, used to launch nodes
2) In Equalizer for render client exits

1) is imo legit. Do you agree?
2) Is a tricky one: An Equalizer application executable can also be used as a
render client. To make this work, one of the initialization functions takes
over and never returns. Therefore it has to call exit. Iirc the method doing
that can be overwritten. Ideas?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]