Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tango-icon-theme-extras - Extra icons from the Tango Project Alias: tango-icons-extras https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222555 ruben@xxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From ruben@xxxxxxxxxxxxxxxx 2007-01-29 02:43 EST ------- Ok, here we go. - package conforms to package naming guidlines - spec file name matches basename - the package is licensed with an open source compatible license - package includes license in %doc - spec file is written in american english - spec file is legible - sources match upstream (sha1sum) 1bed3023139187c36e851df19506f4942bf2d1c1 tango-icon-theme-extras-0.1.0.tar.gz 1bed3023139187c36e851df19506f4942bf2d1c1 tango-icon-theme-extras-0.1.0.tar.gz.1 - package successfully built on my test box (i386) - no need for exclude arch - BR are present and make sense - no libraries, no need to run ldconfig - not relocatable - package owns everything it creates - package does not duplicate files it owns - file attributes are set appropriatly - %clean section present and removes buildroot - consistently uses macros - no large documentation - files in %doc does not affect runtime of application - does not contain a pkgconfig file - does not contain any libraries - does not have a devel package - does not contain any .la files - package does not have a gui - package does not own files/directories owned by other packages. Peter, have you considered reporting the missing CC lincense to the rpmlint maintainer? I don't see any blockers, so this package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review