Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=754437 Erik van Pienbroek <erik-fedora@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |erik-fedora@xxxxxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |erik-fedora@xxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #1 from Erik van Pienbroek <erik-fedora@xxxxxxxxxxxxxxx> 2011-11-30 16:43:25 EST --- Taking for review - The latest upstream version is 0.0.2. Please update to this version - Please replace the %define's at the top of the .spec file with these: %global __strip %{_mingw32_strip} %global __objdump %{_mingw32_objdump} %define __debug_install_post %{_mingw32_debug_install_post} - Please add the line %{?_mingw32_debug_package} between the last %description and the %prep lines. This is required for automatic debuginfo extraction - The BuildRoot tag, the 'rm -rf $RPM_BUILD_ROOT' from the %install section, the entire %clean section and the various %defattr lines can all be dropped as they're not needed any more with recent RPM Next to this I would also like to recommend you to name the package 'mingw-libvirt-glib' (which provides the 'mingw32-libvirt-glib' and other subpackages). We recommend this for new packages so they can easily be adjusted to have mingw-w64 support without requiring a full re-review. Support for mingw-w64 is a planned feature for Fedora 17, but is currently stalled because we're still waiting for legal approval: http://lists.fedoraproject.org/pipermail/legal/2011-November/001754.html An example of a package which uses this new naming scheme can be found at https://fedoraproject.org/wiki/Packaging:MinGW#Example_Specfile -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review