Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=750591 --- Comment #2 from Jaroslav Škarvada <jskarvad@xxxxxxxxxx> 2011-11-30 07:54:55 EST --- Thanks for the review. Hopefully I fixed it all: Spec URL: http://jskarvad.fedorapeople.org/gnuradio/uhd.spec SRPM URL: http://jskarvad.fedorapeople.org/gnuradio/uhd-3.3.0-2.fc14.src.rpm > It looks they call it "GNU Radio" officialy. It's not big problem, but it fixes the warning imho. > I took the description from the upstream, but no problem to fix. > There's license file installed in -doc subpackage, so I presume it could be installed also in the main uhd package according to guidelines. > Basic docs (including license) were moved to base package. > You should use tag instead of revision hash to make it clearer you're using proper version. Just replace git hash with release_003_003_000. > Just comments, but fixed. I also removed defattrs, switched to macros style instead of variables and I moved the binaries to base backage from devel. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review