Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=753354 Juan Orti Alcaine <j.orti.alcaine@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.orti.alcaine@xxxxxxxxx --- Comment #1 from Juan Orti Alcaine <j.orti.alcaine@xxxxxxxxx> 2011-11-29 07:24:36 EST --- Hello, I'm going to informally review your package because I'm not a package maintainer. I also have submited some packages waiting for review and I'm looking for sponsor, so it would be great if you can review some of my packages (#738556 #756445 #756435 #756443) $ rpmlint strongswan-4.6.0-1.fc15.src.rpm strongswan.spec strongswan.src: E: no-changelogname-tag strongswan.src: W: invalid-license GPL 1 packages and 1 specfiles checked; 1 errors, 1 warnings. - It fails to create the RPM binary package in x86_64, because the systemd unit dir is wrong in the spec. - The license name is not valid. I think it should be GPLv2 - In Source0 you must build the url with %{name}-%{version}.tar.gz - BuildRoot is not necessary if you don't plan to build to EPEL - Since you ship a systemd unit file, you must add BuildRequires: systemd-units, take a look at http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd to see how to install the unit files. - If not for EPEL, it's not necessary to clean the build root in %install and the %clean section - Use %{name} instead of strongswan anywhere you can - In %files you can drop the %defattr line - Remove the white line in $files - You must include in %doc all the COPYING, CREDITS, NEWS, README, etc. - To reference the systemd unit dir, you must use: %{_unitdir}/%{name}.service - Use %{_libdir} instead of /usr/%{_lib} - Don't mark the man pages as %doc - For the man pages use %{_mandir}/man3/foo.3.gz - Substitute /usr/libexec for %{_libexecdir} - Add something to the %changelog section -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review