Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libdirac - Dirac is an open source video codec https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221405 ------- Additional Comments From rpm@xxxxxxxxxxxxxx 2007-01-28 17:05 EST ------- Looking good now. Small issue: it is preferable to ship the desktop file separately instead of creating it in %install. These files have names that are IMHO too generic. Maybe rename them to dirac_*? %{_bindir}/BMPtoRGB %{_bindir}/RGBtoBMP %{_bindir}/RGBtoUYVY %{_bindir}/RGBtoYUV* %{_bindir}/UYVYtoRGB %{_bindir}/YUV*toRGB -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review