Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mdbtools - tools for extracting things from Access databases https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223557 ------- Additional Comments From rpm@xxxxxxxxxxxxxx 2007-01-28 16:54 EST ------- ldconfig calls for -devel are unnecessary. You seem to have ignored first part of comment #4, please rename libmdb to libs. Requires: mdbtools-libmdb for main package is redundant. Doesn't build in mock/fc6: Making all in odbc make[2]: Entering directory `/builddir/build/BUILD/mdbtools-0.5/src/odbc' source='odbc.c' object='odbc.lo' libtool=yes \ depfile='.deps/odbc.Plo' tmpdepfile='.deps/odbc.TPlo' \ depmode=gcc3 /bin/sh ../../depcomp \ /usr/bin/libtool --mode=compile gcc -DPACKAGE_NAME=\"\" -DPACKAGE_TARNAME=\"\" -DPACKAGE_VERSION=\"\" -DPACKAGE_ STRING=\"\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE=\"mdbtools\" -DVERSION=\"0.5\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHA VE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDI NT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DYYTEXT_POINTER=1 -DSTDC_HEADERS=1 -DHAVE_FCNTL_H=1 -DHAVE_LIMITS_H=1 -DHAVE_ UNISTD_H=1 -DHAVE_WORDEXP_H=1 -I. -I. -I ../../include `glib-config --cflags` -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOUR CE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -DSQL -DUNIXODBC -c -o odbc.lo `test - f 'odbc.c' || echo './'`odbc.c /bin/sh: glib-config: command not found mkdir .libs gcc -DPACKAGE_NAME=\"\" -DPACKAGE_TARNAME=\"\" -DPACKAGE_VERSION=\"\" -DPACKAGE_STRING=\"\" -DPACKAGE_BUGREPORT=\"\" -D PACKAGE=\"mdbtools\" -DVERSION=\"0.5\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAV E_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H =1 -DYYTEXT_POINTER=1 -DSTDC_HEADERS=1 -DHAVE_FCNTL_H=1 -DHAVE_LIMITS_H=1 -DHAVE_UNISTD_H=1 -DHAVE_WORDEXP_H=1 -I. -I. - I ../../include -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -DSQL -DUNIXODBC -c odbc.c -MT odbc.lo -MD -MP -MF .deps/odbc.TPlo -fPIC -DPIC -o .libs/odbc.o In file included from ../../include/mdbodbc.h:22, from odbc.c:28: ../../include/mdbtools.h:31:18: error: glib.h: No such file or directory Attached patch makes it look for glib2 instead of glib and fixes some minor issues in the code as well, but the rest of the code triggers a lot of gcc warnings. You might want to look through the build log and fix them. With that fix, it builds fine in mock, just some small rpmlint issues: $ rpmlint *.rpm E: mdbtools script-without-shebang /usr/share/doc/mdbtools-0.5/COPYING.LIB -> chmod 644 COPYING.LIB in %prep W: mdbtools-libs summary-not-capitalized libraries for mdbtools -> Capitalize Does the frontend really requires the command line tools or only the libraries? In the latter case, Requires: mdbtools in %package frontend is unnecessary. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review