Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=743615 Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #8 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2011-11-28 17:08:03 EST --- (In reply to comment #7) > (In reply to comment #6) > > > NEEDSWORK: > > - files: > > * %dir %{_sysconfdir}/nagios double owned: > > rpm -qf /etc/nagios > > nagios-3.2.3-11.fc16.x86_64 > > > > This package R nagios-common, which doesn't R nagios, so the directory is > > unowned. It would be best to add the directory to nagios-common: > > Added to the list in bug 756839 > > I wouldn't own it here and wait for nagios-common to pick it up... > > The installed config file is just an example config with everything commented > out. Also, the config file is optional and most users will probably not use it. > In retrospect it shouldn't live in /etc/nagios as this directory should only > contain actual Nagios config files, not config files for plugins. > > In light of this I have removed it from /etc/nagios and only include it as > documentation ("example.conf") instead. Great > > - pre-build binary: > > > > https://fedoraproject.org/wiki/Packaging:Guidelines#No_inclusion_of_pre-built_binaries_or_libraries > > Please delete the check_openmanage.exe binary in %prep, although you don't > > use them later on. > > Done. Yepp. Looks completely fine now. ############################################################### APPROVED ############################################################### You can now proceed and do a SCM request: https://fedoraproject.org/wiki/Package_SCM_admin_requests Information for adding the package to the git repository is at: https://fedoraproject.org/wiki/New_package_process_for_existing_contributors https://fedoraproject.org/wiki/Using_Fedora_GIT Information for shipping the updates to EL and released fedora branches: https://fedoraproject.org/wiki/PackageMaintainers/UpdatingPackageHowTo#Submit_your_update_to_Bodhi Don't hesitate to ask (here or private mail), when you run into any problems. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review