Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=754975 Michael Schwendt <mschwendt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mschwendt@xxxxxxxxx Flag|needinfo?(mschwendt@gmail.c |fedora-review+ |om) | --- Comment #7 from Michael Schwendt <mschwendt@xxxxxxxxx> 2011-11-27 10:18:49 EST --- [pkg-config file changes] > I hope it is correct. Yes, it makes sense to move the external libs into Libs.private. Just that at Fedora we try to avoid static linking, so it might be that some of the libs in Libs.private are not available as -static packages. > - A typo in configure option (--with-pic). :) Didn't make a difference, though. The default pic mode also compiled with -fPIC -DPIC. > - libicu was hardcoded in autoconf. I removed it and libicu-devel in > BuildRequires is no longer needed. Confirmed. BuildRequires now match the list at http://www.pion.org/projects/pion-network-library/libraries however zlib and bzip2 dependency is a mystery, too. They seem to be unused but are linked with. $ grep zlib * -R|grep '#include' common/build/pion-config.inc: AC_TRY_LINK([#include <zlib.h>],[ zlibVersion(); return(0); ], common/build/pion-config.inc: AC_TRY_LINK([#include <bzlib.h>],[ BZ2_bzlibVersion(); return(0); ], configure:#include <zlib.h> configure:#include <bzlib.h> > - Unversioned .so files were moved into the -devel package. Confirmed. * Exlicit -devel Requires could be arch-specific using %{?_isa}. * Upstream download section offers a shorter .tar.bz2 source archive. * APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review