Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=743615 Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841(FE-NEEDSPONSOR) | --- Comment #6 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2011-11-26 09:02:29 EST --- Review: - name ok - noarch not possible (maybe file a featurerequest at nagios to make it possible to install plugins into /usr/share/nagios/plugins?) - BR/R ok - BuildRoot and defattr could be left out, but as you are targeting el5: ok - license ok - no *.la - rpmlint ignorable: $ rpmlint /home/tom/rpmbuild/SRPMS/nagios-plugins-openmanage- 3.7.3-2.fc16.src.rpm /home/tom/rpmbuild/RPMS/x86_64/nagios-plugins- openmanage-3.7.3-2.fc16.x86_64.rpm nagios-plugins-openmanage.x86_64: E: no-binary nagios-plugins-openmanage.x86_64: W: only-non-binary-in-usr-lib 2 packages and 0 specfiles checked; 1 errors, 1 warnings. - no libs - koji scratch build successful: http://koji.fedoraproject.org/koji/taskinfo?taskID=3542984 - source match upstream: 708257eedc7003d9c5fc3fba8200e572 check_openmanage-3.7.3.tar.gz - files: * proper inclusion of man pages * %config there NEEDSWORK: - files: * %dir %{_sysconfdir}/nagios double owned: rpm -qf /etc/nagios nagios-3.2.3-11.fc16.x86_64 This package R nagios-common, which doesn't R nagios, so the directory is unowned. It would be best to add the directory to nagios-common: Added to the list in bug 756839 I wouldn't own it here and wait for nagios-common to pick it up... - pre-build binary: https://fedoraproject.org/wiki/Packaging:Guidelines#No_inclusion_of_pre-built_binaries_or_libraries Please delete the check_openmanage.exe binary in %prep, although you don't use them later on. ############################################################## Let's wait for an answer of the nagios maintainer, but as your package looks fine otherwise and you made valid points in other reviews you are now: ############################################################## SPONSORED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review