Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=750139 --- Comment #4 from Brendan Jones <brendan.jones.it@xxxxxxxxx> 2011-11-24 03:08:16 EST --- Hi Jerry, thanks for the review! I've removed the README form the encoding fix and dropped the buildroot tag. RPM_OPT_FLAGS and %{optflags} are interchangeable [1] >From what I know the waf is not so concerned with backwards compatibility as other build tools (such as cmake) and recommends shipping the waf script. There are no clear guidelines on this - the version of waf used here is actually earlier than the one in f16, so I will leave as is. I have contacted the author with regards to the incorrect license file, stay tuned. thanks Brendan [1] http://fedoraproject.org/wiki/Packaging:Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review