Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libsieve - A library for parsing, sorting and filtering your mail https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216723 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-01-28 00:13 EST ------- Well, * License - Some sources are not licensed under LGPL. + GPL sv_util/*print*.[hc] sv_util/xsize.h As GPL is more strict than LGPL, please modify the whole license of this package to GPL (not a blocker, however, would you tell upstream about this? License text is LGPL, however this package is surely GPL) * Timestamps - This package installs several header files, and in that case keeping timestamps on these files are preferred. For this package, -------------------------------------------------- make install DESTDIR=$RPM_BUILD_ROOT INSTALL="%{__install} -c -p" -------------------------------------------------- will keep timestamps. * Source: - It seems that the newest is 2.2.4. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review