Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=754975 --- Comment #4 from Jan Vcelak <jvcelak@xxxxxxxxxx> 2011-11-23 09:36:35 EST --- Update spec URL: http://jvcelak.fedorapeople.org/review/pion-net/4.0.7-3/pion-net.spec Updated SRPM url: http://jvcelak.fedorapeople.org/review/pion-net/pion-net-4.0.7-3.fc17.src.rpm (In reply to comment #3) > * HTML documentation is also included in the base package. This is because the > %doc macro for the base package installs the files in %_docdir/%name-%version, > which is exactly the path you use in the -doc subpackage. In the same way, the > -doc subpkg duplicates the %doc files from the base pkg %files list. Resolved. Documentation is now in %{_docdir}/pion-net-doc-%{version} > * -devel package is missing dependencies. In the C++ headers I see references > to Boost headers, OpenSSL, log4cpp. It's likely one cannot include pion-net > headers before installing missing -devel packages. Resolved. Added the same -devel libs. > * The pkg-config file is broken in several ways: > - on x86_64, it includes a hardcoded -L/usr/lib > - its Libs definition duplicates the linker args that have been used to link > pion-net itself, not what is necessary to link with pion-net > - the Cflags line needs a second look, in particular where the hardcoded I'm not a pkg-config guru. I have updated the .pc file to include only pion-net libraries in Libs. And added Libs.private to include the external libraries. I hope it is correct. > BOOST_FILESYSTEM_VERSION definition comes from (version 2 is deprecated) > - $datarootdir and $datadir are undefined/unexpanded That's right. The library is not compatible with new boost::filesystem. But I updated the affected parts, there were only a few. The updated package links against boost::filesystems v3 successfully. > * Source doesn't use Fedora's global compiler %optflags. Resolved, I patched the autoconf files not to clear the flags. I found another issues, which were fixed as well: - A typo in configure option (--with-pic). - libicu was hardcoded in autoconf. I removed it and libicu-devel in BuildRequires is no longer needed. - Unversioned .so files were moved into the -devel package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review